Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openvrml - VRML/X3D runtime library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212715 ------- Additional Comments From braden@xxxxxxxxxxxxx 2006-11-14 02:44 EST ------- (In reply to comment #11) > One more thing. Looks like there is a test suite that can be executed using make > check. It seems to run properly even if $DISPLAY is not set, so please include > it in the specfile, i.e.: > > %check > %{__make} check Except there's a crash-on-exit bug lurking somewhere that one of the test cases triggers *some* of the time. (In reply to comment #12) > Any package that contains a *.pc MUST directly "Require: pkgconfig" to make sure > %{_libdir}/pkgconfig has an owner. Understood. > > > 2. use BuildRequires: gecko-devel instead of firefox-devel > I fail to understand this. Not sure I do either; but for the reason I already mentioned, I think it's moot. > > > 4. use %setup -q instead of %setup > Optional. What's it do? > > > 5. use %configure --disable-dependency-tracking to speed up build process > > Optional, left to the packager's preference. This doesn't make much sense for > this package, because this speed up is marginal for this package. True; I won't bother with it, at least for now. > > > 7. avoid unnecessary docs duplication in every subpackage > > > > Users shouldn't need to be aware of the package dependency chain in order to > > find the README or license for the package. Would it be acceptable to install > > symlinks? > No. Okay. I'll leave it as-is. (In reply to comment #13) > I tried actually using it and it seems that the firefox plugin requires -gtkplug > subpackage to run at all. Yes; there *is* a Requires to that effect. > Also, it's extremely slow without hardware accelerated > OpenGL, but that's to be expected. There's also a bug that makes the plug-in soak up CPU cycles, which doesn't help matters. *** spec: http://endoframe.com/openvrml.spec srpm: http://endoframe.com/openvrml-0.16.1-3.src.rpm I hope I haven't missed anything. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review