[Bug 484051] Review Request: sockettest - Test My Socket

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484051

PRABIN DATTA <prabindatta@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?

--- Comment #3 from PRABIN DATTA <prabindatta@xxxxxxxxx> 2010-08-06 19:37:45 EDT ---
==MUST: rpmlint must be run on every package. The output should be posted in
the review.==

** rpmlint **
output:
$ rpmlint SRPMS/sockettest-3.0-1.fc10.src.rpm
sockettest.src: W: strange-permission sockettest 0755L
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint rpmbuild/RPMS/i686/sockettest-3.0-1.fc13.i686.rpm
sockettest.i686: E: no-binary
sockettest.i686: W: no-manual-page-for-binary sockettest
1 packages and 0 specfiles checked; 1 errors, 1 warnings.


==MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.==

**Compliling errors**
[javac] Compiling 13 source files to
/home/prabindatta/rpmbuild/BUILD/SocketTest/build/classes
    [javac] ----------
    [javac] 1. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/MyTrustManager.java
(at line 27)
    [javac]     KeyStore ks = null;
    [javac]              ^^
    [javac] The local variable ks is never read
    [javac] ----------
    [javac] ----------
    [javac] 2. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/PortModel.java
(at line 13)
    [javac]     public class PortModel extends AbstractTableModel {
    [javac]                  ^^^^^^^^^
    [javac] The serializable class PortModel does not declare a static
final serialVersionUID field of type long
    [javac] ----------
    [javac] ----------
    [javac] 3. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/SocketTest.java
    [javac]  (at line 4)
    [javac]     import java.applet.*;
    [javac]            ^^^^^^^^^^^
    [javac] The import java.applet is never used
    [javac] ----------
    [javac] 4. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/SocketTest.java
    [javac]  (at line 5)
    [javac]     import java.awt.event.*;
    [javac]            ^^^^^^^^^^^^^^
    [javac] The import java.awt.event is never used
    [javac] ----------
    [javac] 5. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/SocketTest.java
    [javac]  (at line 7)
    [javac]     import javax.swing.event.*;
    [javac]            ^^^^^^^^^^^^^^^^^
    [javac] The import javax.swing.event is never used
    [javac] ----------
    [javac] 6. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/SocketTest.java
    [javac]  (at line 8)
    [javac]     import javax.swing.border.*;
    [javac]            ^^^^^^^^^^^^^^^^^^
    [javac] The import javax.swing.border is never used
    [javac] ----------
    [javac] 7. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/SocketTest.java
    [javac]  (at line 19)
    [javac]     public class SocketTest extends JFrame {
    [javac]                  ^^^^^^^^^^
    [javac] The serializable class SocketTest does not declare a
static final serialVersionUID field of type long
    [javac] ----------
    [javac] ----------
    [javac] 8. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/UdpServer.java
(at line 4)
    [javac]     import java.io.*;
    [javac]            ^^^^^^^
    [javac] The import java.io is never used
    [javac] ----------
    [javac] ----------
    [javac] 9. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/About.java
(at line 4)
    [javac]     import java.awt.event.*;
    [javac]            ^^^^^^^^^^^^^^
    [javac] The import java.awt.event is never used
    [javac] ----------
    [javac] 10. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/About.java
(at line 6)
    [javac]     import javax.swing.event.*;
    [javac]            ^^^^^^^^^^^^^^^^^
    [javac] The import javax.swing.event is never used
    [javac] ----------
    [javac] 11. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/About.java
(at line 7)
    [javac]     import javax.swing.border.*;
    [javac]            ^^^^^^^^^^^^^^^^^^
    [javac] The import javax.swing.border is never used
    [javac] ----------
    [javac] 12. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/About.java
(at line 15)
    [javac]     public class About extends JPanel /*JFrame*/ {
    [javac]                  ^^^^^
    [javac] The serializable class About does not declare a static
final serialVersionUID field of type long
    [javac] ----------
    [javac] ----------
    [javac] 13. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/PortDialog.ja
    [javac] va (at line 4)
    [javac]     import javax.swing.table.*;
    [javac]            ^^^^^^^^^^^^^^^^^
    [javac] The import javax.swing.table is never used
    [javac] ----------
    [javac] 14. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/PortDialog.ja
    [javac] va (at line 6)
    [javac]     import java.io.IOException;
    [javac]            ^^^^^^^^^^^^^^^^^^^
    [javac] The import java.io.IOException is never used
    [javac] ----------
    [javac] 15. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/PortDialog.ja
    [javac] va (at line 14)
    [javac]     public class PortDialog extends JDialog {
    [javac]                  ^^^^^^^^^^
    [javac] The serializable class PortDialog does not declare a
static final serialVersionUID field of type long
    [javac] ----------
    [javac] ----------
    [javac] 16. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestClient.java
(at line 6)
    [javac]     import javax.swing.event.*;
    [javac]            ^^^^^^^^^^^^^^^^^
    [javac] The import javax.swing.event is never used
    [javac] ----------
    [javac] 17. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestClient.java
(at line 14)
    [javac]     import javax.net.*;
    [javac]            ^^^^^^^^^
    [javac] The import javax.net is never used
    [javac] ----------
    [javac] 18. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestClient.java
(at line 22)
    [javac]     public class SocketTestClient extends JPanel {
    [javac]                  ^^^^^^^^^^^^^^^^
    [javac] The serializable class SocketTestClient does not declare a
static final serialVersionUID field of type long
    [javac] ----------
    [javac] 19. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestCli
    [javac] ent.java (at line 127)
    [javac]     dia.show();
    [javac]     ^^^^^^^^^^
    [javac] The method show() from the type Dialog is deprecated
    [javac] ----------
    [javac] ----------
    [javac] 20. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestSer
    [javac] ver.java (at line 6)
    [javac]     import javax.swing.event.*;
    [javac]            ^^^^^^^^^^^^^^^^^
    [javac] The import javax.swing.event is never used
    [javac] ----------
    [javac] 21. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestSer
    [javac] ver.java (at line 18)
    [javac]     public class SocketTestServer extends JPanel /*JFrame*/ {
    [javac]                  ^^^^^^^^^^^^^^^^
    [javac] The serializable class SocketTestServer does not declare a
static final serialVersionUID field of type long
    [javac] ----------
    [javac] 22. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestServer.java
(at line 123)
    [javac]     dia.show();
    [javac]     ^^^^^^^^^^
    [javac] The method show() from the type Dialog is deprecated
    [javac] ----------
    [javac] ----------
    [javac] 23. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestUdp.java
(at line 6)
    [javac]     import javax.swing.event.*;
    [javac]            ^^^^^^^^^^^^^^^^^
    [javac] The import javax.swing.event is never used
    [javac] ----------
    [javac] 24. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestUdp.java
(at line 18)
    [javac]     public class SocketTestUdp extends JPanel /*JFrame*/ {
    [javac]                  ^^^^^^^^^^^^^
    [javac] The serializable class SocketTestUdp does not declare a
static final serialVersionUID field of type long
    [javac] ----------
    [javac] 25. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestUdp
    [javac] .java (at line 60)
    [javac]     private DatagramPacket packet;
    [javac]                            ^^^^^^
    [javac] The field SocketTestUdp.packet is never read locally
    [javac] ----------
    [javac] 26. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SocketTestUdp
    [javac] .java (at line 128)
    [javac]     dia.show();
    [javac]     ^^^^^^^^^^
    [javac] The method show() from the type Dialog is deprecated
    [javac] ----------
    [javac] ----------
    [javac] 27. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SplashScreen.
    [javac] java (at line 5)
    [javac]     import javax.swing.border.*;
    [javac]            ^^^^^^^^^^^^^^^^^^
    [javac] The import javax.swing.border is never used
    [javac] ----------
    [javac] 28. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SplashScreen.
    [javac] java (at line 6)
    [javac]     import java.awt.event.*;
    [javac]            ^^^^^^^^^^^^^^
    [javac] The import java.awt.event is never used
    [javac] ----------
    [javac] 29. WARNING in
/home/prabindatta/rpmbuild/BUILD/SocketTest/src/net/sf/sockettest/swing/SplashScreen.
    [javac] java (at line 13)
    [javac]     public class SplashScreen extends JWindow {
    [javac]                  ^^^^^^^^^^^^
    [javac] The serializable class SplashScreen does not declare a
static final serialVersionUID field of type long
    [javac] ----------
    [javac] 29 problems (29 warnings)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]