Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620990 --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-06 15:21:08 EDT --- Created an attachment (id=437243) --> (https://bugzilla.redhat.com/attachment.cgi?id=437243) Patch to display ipraytime in UTF-8 Some notes: * SourceURL - For sourceforge hosted tarball, please follow: https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net * BuildRoot - is no longer needed on Fedora and EPEL6: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * Version specific BR (BuildRequires) - ">= 0.7.0" part on "BR: libitl-devel" is not needed because libitl-devel on all supported Fedora branches support this version. https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires * Calling autotools - Why do you execute autogen.sh although configure or so already exists in the tarball? (By the way, if there is some reason you want to execute autogen.sh, at least "BR: autoconf" is needed). * Documents - Including license text (in this case "COPYING" file) is mandatory (if exists) - Also including "README" as %doc is preferred. * ISO-8859-1 -> UTF-8 - By the way, $ ipraytime returns: ------------------------------------------------------------------ $ ipraytime Prayer schedule for, City : Makkah Latitude : 021� 25' 14" N Longitude : 039� 49' 49" E Angle Method : Umm Al-Qurra University TimeZone : UTC+3.0 Qibla : 067� 26' 21" W of true North ------------------------------------------------------------------- Some characters are under ISO-8859-1 and they are displayed in garbage characters. Please consider to apply the attached patch to make ipraytime displayed in UTF-8. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review