Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617592 --- Comment #12 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-08-06 08:28:30 EDT --- The package is almost ready. There are just a few minor things left, you should address: - Add a short comment above Patch0 telling what it does. Did you send the patch to the developer(s)? I think the changes should be applied upstream. - Drop the word "the" in the description of the devel package (otherwise the sentence sounds strange to me), and preferably replace "accounts-qt" with "libaccounts-qt" (or %{name}). - As suggested in comment #5, I recommend to move the API docs to %{_docdir}/libaccounts-qt. Using different "namespaces", i.e libaccounts-qt and accounts-qt, for the license file and the API docs is confusing. I'd expect the latter to be located in a folder starting with %{name}. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review