Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=601577 --- Comment #23 from Till Maas <opensource@xxxxxxxxx> 2010-08-06 08:18:32 EDT --- Ok, the spec looks very good now. Two minor changes you can do in case there is some other major change or if you import it into Fedora: - Please use %{_mandir}/man1/dotlockfile.1* and not %{_mandir}/man1/dotlockfile.1.* - there is one less fullstop, which makes the globbing pattern match even if the manpage is not compressed at all - Please change the description / summary for the devel package to: Summary: Development files for %{name} %description devel The %{name}-devel package contains libraries and header files for developing applications that use %{name}. These are the default values created by rpmdev-newspec and the current one only mentions the header files, but there is also the .so symlink included. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review