Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=601577 --- Comment #20 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 2010-08-06 06:21:14 EDT --- OK, as Till suggested, the missing link gets created from spec. -devel-subpackage requires the main package; main package contains COPYRIGHT etc. lockfile builds just one library (liblockfile.so) a link is generated to liblockfile.so.1.0 and a link to liblockfile.so.1 If I understand the packaging guide correctly, lockfile.so should go to -devel subpackage and versioned libs should go to -libs. The -libs-subpackage would contain only 2 links to lockfile.so and should require -devel subpackage. This wouldn't make sense. Where should I place liblockfile and its links? Currently, they are packed in -devel rpm -qpvl ../RPMS/i686/lockfile-devel-1.08-7.fc13.i686.rpm -rw-r--r-- 1 root root 1469 Aug 6 12:05 /usr/include/lockfile.h -rw-r--r-- 1 root root 878 Aug 6 12:05 /usr/include/maillock.h lrwxrwxrwx 1 root root 18 Aug 6 12:05 /usr/lib/liblockfile.so -> liblockfile.so.1.0 lrwxrwxrwx 1 root root 27 Aug 6 12:05 /usr/lib/liblockfile.so.1 -> /usr/lib/liblockfile.so.1.0 -rwxr-xr-x 1 root root 7736 Aug 6 12:05 /usr/lib/liblockfile.so.1.0 -rw-r--r-- 1 root root 2960 Aug 6 12:05 /usr/share/man/man3/lockfile_create.3.gz -rw-r--r-- 1 root root 1234 Aug 6 12:05 /usr/share/man/man3/maillock.3.gz ------- diff -u --- lockfile.spec-6 2010-08-06 10:46:39.000000000 +0200 +++ lockfile.spec 2010-08-06 12:04:11.000000000 +0200 @@ -1,6 +1,6 @@ Name: lockfile Version: 1.08 -Release: 6%{?dist} +Release: 7%{?dist} Summary: This implements a number of functions found in -lmail on SysV systems Group: Applications/System @@ -33,8 +33,6 @@ # remove -g root from install sed -i "s/install -g root -m 755 dotlockfile \$(ROOT)\$(bindir);/install -m 755 dotlockfile \$(ROOT)\$(bindir);/" Makefile.in -# remove link-creation from Makefile (to be done later during install) -sed -i "s/ln -s liblockfile.so.\$(VER) \$(ROOT)\$(libdir)\/liblockfile.so//" Makefile.in %build %configure --enable-shared @@ -52,7 +50,6 @@ make ROOT=%{buildroot} install_shared # create links for ldconfig -ln -s %{_libdir}/liblockfile.so.1.0 %{buildroot}/%{_libdir}/liblockfile.so ln -s %{_libdir}/liblockfile.so.1.0 %{buildroot}/%{_libdir}/liblockfile.so.1 %clean @@ -75,10 +72,13 @@ %{_libdir}/*.so* %{_includedir}/* %{_mandir}/man3/* -%doc COPYRIGHT %changelog +* Fri Aug 6 2010 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 1.08-7 +- remove COPYRIGHT from devel +- just fix one missing link from upstream + * Thu Aug 5 2010 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 1.08-6 - include COPYRIGHT in -devel, too - remove unnecessary exclude ---------- [mrunge@mrungexp SPECS]$ rpmlint /home/mrunge/rpmbuild/SRPMS/lockfile-1.08-7.fc13.src.rpm /home/mrunge/rpmbuild/RPMS/i686/lockfile-1.08-7.fc13.i686.rpm /home/mrunge/rpmbuild/RPMS/i686/lockfile-devel-1.08-7.fc13.i686.rpm /home/mrunge/rpmbuild/RPMS/i686/lockfile-debuginfo-1.08-7.fc13.i686.rpm lockfile.src: W: spelling-error Summary(en_US) lmail -> mail, email, l mail lockfile.src: W: spelling-error %description -l en_US lmail -> mail, email, l mail lockfile.i686: W: spelling-error Summary(en_US) lmail -> mail, email, l mail lockfile.i686: W: spelling-error %description -l en_US lmail -> mail, email, l mail 4 packages and 0 specfiles checked; 0 errors, 4 warnings. SPEC: http://www.matthias-runge.de/fedora/lockfile.spec SRPM: http://www.matthias-runge.de/fedora/lockfile-1.08-7.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review