Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openvrml - VRML/X3D runtime library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212715 rc040203@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Additional Comments From rc040203@xxxxxxxxxx 2006-11-13 20:39 EST ------- (In reply to comment #9) > (In reply to comment #6) > > I'm interested in having this in Extras, too. A few comments: > > 1. redundant BuildRequires: pkgconfig (required by freetype-devel and > > libpng-devel), libpng-devel (required by cairo-devel, which is required by > > gtk2-devel), fontconfig-devel (required by cairo-devel), freetype-devel > > (required by fontconfig-devel) > > Okay. Presumably making openvrml-devel Require freetype-devel would moot Ralf's > suggestion that openvrml-devel should Require pkgconfig. Any package that contains a *.pc MUST directly "Require: pkgconfig" to make sure %{_libdir}/pkgconfig has an owner. > > 2. use BuildRequires: gecko-devel instead of firefox-devel I fail to understand this. > > 4. use %setup -q instead of %setup Optional. > > 5. use %configure --disable-dependency-tracking to speed up build process Optional, left to the packager's preference. This doesn't make much sense for this package, because this speed up is marginal for this package. > > 7. avoid unnecessary docs duplication in every subpackage > > Users shouldn't need to be aware of the package dependency chain in order to > find the README or license for the package. Would it be acceptable to install > symlinks? No. > > 8. rename mozilla-plugin to plugin > > No. There are lots of kinds of plug-ins. This package makes a Mozilla/Gecko > one. I might entertain changing it to "gecko-plugin"; but since "Mozilla plug- > in" or "Netscape plug-in" is what everyone calls these things, that's going to > be a tough sell. ACK. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review