[Bug 214872] Review Request: Ri-li - Arcade game where you drive a toy wood engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Ri-li - Arcade game where you drive a toy wood engine
Alias: Ri-li

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214872


chris.stone@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chris.stone@xxxxxxxxx  2006-11-13 21:26 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec legible
- sources match upstream
e6dfa35616f5c84eb14ff82517cea796  Ri-li-2.0.0.tar.bz2
- package successfully compiles and builds on FC6 x86_64
- all build dependencies are listed in BR
- package does not use locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicates in %files
- file permissions set properly
- contains proper %clean
- macro usage consistent
- contains code
- no large documentation files
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no need for devel subpackage
- no .la files
- contains proper .desktop file
- package does not own files or directories owned by other packages

APPROVED

==== SHOULD ====
- Remove SDL-devel from BR, SDL_Mixer-devel should pick it up


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]