Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621242 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-05 03:44:22 EDT --- Okay. (In reply to comment #2) > (In reply to comment #1) > > Some notes: > > > > ! Unneeded macros > > - You can remove %python_sitearch definition because it is uses nowhere. > > It was necessary to build on f12: > https://fedoraproject.org/wiki/Packaging:Python#Macros - Well, what I meant here is while %python_sitelib definition is needed for F=12, %python_sitearch definition is unneeded (because this is noarch), however not a blocker. --------------------------------------------------------------- This package (gyp) is APPROVED by mtasaka --------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review