Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openvrml - VRML/X3D runtime library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212715 ------- Additional Comments From rpm@xxxxxxxxxxxxxx 2006-11-13 16:51 EST ------- (In reply to comment #9) > (In reply to comment #6) > > I'm interested in having this in Extras, too. A few comments: > > 1. redundant BuildRequires: pkgconfig (required by freetype-devel and > > libpng-devel), libpng-devel (required by cairo-devel, which is required by > > gtk2-devel), fontconfig-devel (required by cairo-devel), freetype-devel > > (required by fontconfig-devel) > > Okay. Presumably making openvrml-devel Require freetype-devel would moot > Ralf's suggestion that openvrml-devel should Require pkgconfig. As a result, yes. > > 2. use BuildRequires: gecko-devel instead of firefox-devel and libGLU-devel > > instead of mesa-libGLU-devel > > Re: gecko-devel, I don't think I can do that. I think the change that does > need to be made is for openvrml to Require firefox = 1.5.0.8. Note that > libopenvrml links with libmozjs, which lives in a versioned subdirectory. > Consequently, openvrml-devel would Require firefox-devel = 1.5.0.8. OK, I guess this is moot, because the only package providing gecko-devel is firefox-devel. > > 3. reduntant Requires: mesa-libGLU for -gl subpackage > > Why is that redundant? $ rpm -qpR openvrml-gl-0.16.1-1.x86_64.rpm ... libGLU.so.1()(64bit) ... $ rpm -q --whatprovides "libGLU.so.1()(64bit)" mesa-libGLU-6.5.1-7.fc6.x86_64 That's why. > > 7. avoid unnecessary docs duplication in every subpackage > > Users shouldn't need to be aware of the package dependency chain in order to > find the README or license for the package. Would it be acceptable to install > symlinks? Well, I'll leave that for Ralf to decide. IMHO people are clueful enough to search in openvrml-%version if they can't find it in openvrml-mozilla-plugin-%version. > > 8. rename mozilla-plugin to plugin > > No. There are lots of kinds of plug-ins. This package makes a Mozilla/Gecko > one. I might entertain changing it to "gecko-plugin"; but since "Mozilla plug- > in" or "Netscape plug-in" is what everyone calls these things, that's going to > be a tough sell. OK. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review