Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609473 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-04 15:36:42 EDT --- Some notes: * %define -> %global - Now we prefer to use %global instead of %define https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * Requires for rubygem related packages - We prefer to use "rubygem(foo)" style for (Build)Requires. ref: (this is for perl related packages, howver can be applied to rubygem related packages) https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides * Directory ownership issue - "%{_datadir}/icons/hicolor" (and its subdirectories) are already owned by hicolor-icon-theme and this package should not own these directories. * Scriptlets - For icons under %_datadir/icons/hicolor, please follow https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache * runtime error ------------------------------------------------------------------ $ kaya-board-qt /usr/bin/kaya-board-qt:10:in `require': no such file to load -- /usr/share/kde4/apps/kaya/lib/kaya.rb (LoadError) from /usr/bin/kaya-board-qt:10 ------------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review