Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621242 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |619395 AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-04 14:34:36 EDT --- Some notes: ! Unneeded macros - You can remove %python_sitearch definition because it is uses nowhere. * Release -------------------------------------------------------- Release: 0.1.%{?revision:%{revision}svn}%{?dist} -------------------------------------------------------- - Well, I guess you meant "0.1%{?revision:.%{revision}svn}%{?dist}" * BuildRoot - BuildRoot tag is no longer needed on Fedora and EPEL6: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * BR for python - Please specify python2 or python3. ref: https://fedoraproject.org/wiki/Packaging/Python#BuildRequires - Build fails on F-12 without BR: python2-devel: http://koji.fedoraproject.org/koji/taskinfo?taskID=2379955 * %{__python} setup.py install - Maybe there is only small difference, however I guess we usually add "--skip-build" to "python setup.py install". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review