Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620826 --- Comment #3 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-08-04 13:34:50 EDT --- (In reply to comment #2) > Thanks for your comments. > > (In reply to comment #1) > > Just some comments (I'm no sponsor anyway): > > I don't need a sponsor, I have 20+ packages in Fedora already, but mostly java > and this was my first python package from scratch. I guess I confused you when > I said "first python package" :-) Removing FE_NEEDSPONSOR. Most new contributers forget blocking FE-NEEDSPONSOR, so as soon as I read "new package", I block it everywhere. The "python" in the middle didn't help her much ;) > > - You could add a %check section for running the testsuite. > > checks fail in mock so I didn't put them in. I "fixed" this by adding commented > out check run with explanation why it was disabled. Huh? How is it failing? Maybe just a missing BR? It works here with rpmbuild: + /usr/bin/python test.py test.py:80: DeprecationWarning: the sets module is deprecated from sets import Set Imported 1 modules in 0.278s ---------------------------------------------------------------------- Ran 36 tests in 0.124s OK -> scratch build F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2379894 Failed example: g Expected: (37.386012999999998, -122.082932) Got: (37.386013, -122.082932) There it's failing because python 2.7 seems to round a bit different, than python 2.6 did (and the tests were written for python 2.6). Maybe the next version will fix the doctests, because the author will switch to python 2.7 too... (But here with python-2.6.4-27.fc13.x86_64 it's working for me.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review