Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620738 --- Comment #5 from Steve Traylen <steve.traylen@xxxxxxx> 2010-08-04 09:03:59 EDT --- (In reply to comment #4) > Final changes: > > 1. Please remove the code to add and remove entries to /etc/ld.so.preload. On > Fedora installing a package should not change default behavior like this. > Instead, provide instructions to the admin for how to preload the library. That's done, have added a README.Fedora instead. > > 2. Both %post and %postun need to call ldconfig. Please see: > > http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > They did already but do now as well. Spec URL: http://cern.ch/straylen/rpms/snoopy/snoopy.spec SRPM URL: http://cern.ch/straylen/rpms/snoopy/snoopy-1.6.1-3.el5.src.rpm > With those changes, I'll approve this package. I'll take another look at yours. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review