Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621037 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-08-04 07:45:34 EDT --- Sources match upstream. License verified from MultiMethods.pm. Homepage verified. Description verified. BuldRequires and Requiers verified. Spec file in line with generic and Perl specific packaging guidelines. All tests pass. Builds in dist-f15 buildroot. # rpmlint perl-MooseX-MultiMethods.spec ../SRPMS/perl-MooseX-MultiMethods-0.10-1.fc14.src.rpm ../RPMS/noarch/perl-MooseX-MultiMethods-0.10-1.fc14.noarch.rpm perl-MooseX-MultiMethods.spec: W: no-cleaning-of-buildroot %clean perl-MooseX-MultiMethods.spec: W: no-buildroot-tag perl-MooseX-MultiMethods.spec: W: no-%clean-section perl-MooseX-MultiMethods.src: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti perl-MooseX-MultiMethods.src: W: spelling-error %description -l en_US multi -> mulch, mufti perl-MooseX-MultiMethods.src: W: no-cleaning-of-buildroot %clean perl-MooseX-MultiMethods.src: W: no-buildroot-tag perl-MooseX-MultiMethods.src: W: no-%clean-section perl-MooseX-MultiMethods.noarch: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti perl-MooseX-MultiMethods.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti 2 packages and 1 specfiles checked; 0 errors, 10 warnings. The on-%clean and no-buildroot warnings are bogus because this is post-EPEL-5 package. The spelling warnings are bogus either. rpmlint considered happy. # rpm -pq --requires ../RPMS/noarch/perl-MooseX-MultiMethods-0.10-1.fc14.noarch.rpm |sort |uniq -d perl(aliased) perl(Devel::PartialDump) perl(Moose) perl(MooseX::Types::Moose) perl(namespace::autoclean) perl(Sub::Install) These run-time dependencies are double-specified as they are auto-detected by rpmbuild. Packager is advised to remove corresponding explicit Requires statements from spec file. # rpm -pq -lv ../RPMS/noarch/perl-MooseX-MultiMethods-0.10-1.fc14.noarch.rpm drwxr-xr-x 2 root root 0 srp 4 13:15 /usr/share/doc/perl-MooseX-MultiMethods-0.10 -rw-r--r-- 1 root root 1395 led 3 2010 /usr/share/doc/perl-MooseX-MultiMethods-0.10/Changes -rw-r--r-- 1 root root 18261 led 3 2010 /usr/share/doc/perl-MooseX-MultiMethods-0.10/LICENSE -rw-r--r-- 1 root root 327 led 3 2010 /usr/share/doc/perl-MooseX-MultiMethods-0.10/README -rw-r--r-- 1 root root 441 led 3 2010 /usr/share/doc/perl-MooseX-MultiMethods-0.10/dist.ini -rw-r--r-- 1 root root 2441 srp 4 13:15 /usr/share/man/man3/MooseX::MultiMethods.3pm.gz -rw-r--r-- 1 root root 1926 srp 4 13:15 /usr/share/man/man3/MooseX::MultiMethods::Meta::Method.3pm.gz drwxr-xr-x 2 root root 0 srp 4 13:15 /usr/share/perl5/MooseX drwxr-xr-x 2 root root 0 srp 4 13:15 /usr/share/perl5/MooseX/MultiMethods -rw-r--r-- 1 root root 4887 led 3 2010 /usr/share/perl5/MooseX/MultiMethods.pm drwxr-xr-x 2 root root 0 srp 4 13:15 /usr/share/perl5/MooseX/MultiMethods/Meta -rw-r--r-- 1 root root 1816 led 3 2010 /usr/share/perl5/MooseX/MultiMethods/Meta/Method.pm File system layout and file attributes are correct. Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review