Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619928 --- Comment #5 from Lubomir Rintel <lkundrak@xxxxx> 2010-08-04 01:26:20 EDT --- Thanks. A couple more things: 3.) # FIXME Originálně obsahuje groovy-all-1.5.7.jar, groovy-engine.jar # groovy se zeptat lkundraka In current version of package you may safely drop them as they are. Alternatively, you may choose to package the tools from src/main/groovy if you find them useful. If you choose to do so, you can decide whether to build them into .jars at package build time (preferred) and add groovy BR, or leave them as they are (the source form) and drag groovy interpreter as binary package dependency. In any case, please replace "rm -v libs/{derby,jdbc}*.jar" with a statement that would drop all jars; and do not install them in %install. 4.) This is not a wise thing to do: "ant -Dlibs=%{_javadir}" Javadir can grow too big and apart from java being slow, you easily loose track of jars you depend on. A better solution would be to drop the -Dlibs argument and prepend the call to ant with something like: build-jar-repository libs tigase-utils tigase-xmltools 5.) Please comment on why are you missing the %check section with ant run-unittest command. (It seems to me that it is missing dependency on wttols which provides the unitgen task, right?) 6.) The startup script does not seem to work bash-4.1# /usr/share/tigase/scripts/tigase.sh No params-file.conf given. Using: '/etc/tigase/tigase.conf' /usr/bin/build-classpath: error: Could not find groovy-all-1.5.7 Java extension for this JVM /usr/bin/build-classpath: error: Could not find groovy-engine Java extension for this JVM /usr/bin/build-classpath: error: Some specified jars were not found JAVA_HOME is not set. Please set it to correct value before starting the sever. JAVA_HOME makes little sense in jpackage environment. Please drop the check, or hardcode the value to /usr/lib/jvm. 7.) /etc/tigase/tigase.conf contains both user modifiable and non-user-modifiable settings. Therefore, in case the user e.g. tunes the VM for higher heap size, and another version of the package adds new jar to the default classpath, an update results in non-functional configuration. Please consider splitting the file into two. 8.) Why does /etc/tigase/database go into /etc? Seems to me like like it's not configuration, but data; and thus should go into /usr/share. Hopefully that's all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review