[Bug 619518] Review Request: aajohan-comfortaa - Modern style true type font

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619518

--- Comment #17 from Adam Miller <maxamillion@xxxxxxxxxxxxxxxxx> 2010-08-03 16:59:33 EDT ---
YES - Package meets naming and packaging guidelines
YES - Spec file matches base package name.
YES - Spec has consistant macro usage.
YES - Meets Packaging Guidelines.
YES - License
YES - License field in spec matches
YES - License file included in package
YES - Spec in American English
YES - Spec is legible.
YES - Sources match upstream md5sum:

NA - Package needs ExcludeArch
YES - BuildRequires correct
NA - Spec handles locales/find_lang
NA - Package is relocatable and has a reason to be.
NA - Package has %defattr and permissions on files is good.
YES - Package has a correct %clean section.
YES - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
YES - Package is code or permissible content.
NA - Doc subpackage needed/used.
YES - Packages %doc files don't affect runtime.

NA - Headers/static libs in -devel subpackage.
NA - Spec has needed ldconfig in post and postun
NA - .pc files in -devel subpackage/requires pkgconfig
NA - .so files in -devel subpackage.
NA - -devel package Requires: %{name} = %{version}-%{release}
NA - .la files are removed.

NA - Package is a GUI app and has a .desktop file

YES - Package compiles and builds on at least one arch.
YES - Package has no duplicate files in %files.
YES - Package doesn't own any directories other packages own.
YES - Package owns all the directories it creates.
YES - No rpmlint output.
YES - final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

[15:56:22][adam@turnip][result]+ for i in *rpm; do echo $i; rpm -qp --provides
$i; echo =; rpm -qp --requires $i; echo; done
aajohan-comfortaa-fonts-1.003-3.fc13.noarch.rpm
config(aajohan-comfortaa-fonts) = 1.003-3.fc13
font(:lang=aa)  
font(:lang=af)  
font(:lang=an)  
font(:lang=ast)  
font(:lang=av)  
font(:lang=ay)  
font(:lang=be)  
font(:lang=bg)  
font(:lang=bi)  
font(:lang=br)  
font(:lang=bs)  
font(:lang=bua)  
font(:lang=ca)  
font(:lang=ce)  
font(:lang=ch)  
font(:lang=co)  
font(:lang=crh)  
font(:lang=cs)  
font(:lang=csb)  
font(:lang=cy)  
font(:lang=da)  
font(:lang=de)  
font(:lang=el)  
font(:lang=en)  
font(:lang=eo)  
font(:lang=es)  
font(:lang=et)  
font(:lang=eu)  
font(:lang=fi)  
font(:lang=fil)  
font(:lang=fj)  
font(:lang=fo)  
font(:lang=fr)  
font(:lang=fur)  
font(:lang=fy)  
font(:lang=gd)  
font(:lang=gl)  
font(:lang=gv)  
font(:lang=ho)  
font(:lang=hr)  
font(:lang=hsb)  
font(:lang=ht)  
font(:lang=hu)  
font(:lang=ia)  
font(:lang=id)  
font(:lang=ie)  
font(:lang=ik)  
font(:lang=io)  
font(:lang=is)  
font(:lang=it)  
font(:lang=jv)  
font(:lang=kaa)  
font(:lang=ki)  
font(:lang=kj)  
font(:lang=kk)  
font(:lang=kl)  
font(:lang=ku-tr)  
font(:lang=kum)  
font(:lang=kwm)  
font(:lang=ky)  
font(:lang=la)  
font(:lang=lb)  
font(:lang=lez)  
font(:lang=lg)  
font(:lang=li)  
font(:lang=lt)  
font(:lang=lv)  
font(:lang=mg)  
font(:lang=mh)  
font(:lang=mn-mn)  
font(:lang=ms)  
font(:lang=mt)  
font(:lang=na)  
font(:lang=nb)  
font(:lang=nds)  
font(:lang=ng)  
font(:lang=nl)  
font(:lang=nn)  
font(:lang=no)  
font(:lang=nr)  
font(:lang=nso)  
font(:lang=ny)  
font(:lang=oc)  
font(:lang=om)  
font(:lang=os)  
font(:lang=pap-an)  
font(:lang=pap-aw)  
font(:lang=pl)  
font(:lang=pt)  
font(:lang=rm)  
font(:lang=rn)  
font(:lang=ru)  
font(:lang=rw)  
font(:lang=sc)  
font(:lang=se)  
font(:lang=sel)  
font(:lang=sg)  
font(:lang=sk)  
font(:lang=sl)  
font(:lang=sma)  
font(:lang=smj)  
font(:lang=smn)  
font(:lang=sn)  
font(:lang=so)  
font(:lang=sq)  
font(:lang=sr)  
font(:lang=ss)  
font(:lang=st)  
font(:lang=su)  
font(:lang=sv)  
font(:lang=sw)  
font(:lang=tk)  
font(:lang=tl)  
font(:lang=tn)  
font(:lang=tr)  
font(:lang=ts)  
font(:lang=tt)  
font(:lang=tyv)  
font(:lang=uk)  
font(:lang=uz)  
font(:lang=vo)  
font(:lang=vot)  
font(:lang=wa)  
font(:lang=wen)  
font(:lang=wo)  
font(:lang=xh)  
font(:lang=yap)  
font(:lang=za)  
font(:lang=zu)  
font(comfortaa)  
aajohan-comfortaa-fonts = 1.003-3.fc13
=
/bin/sh  
/bin/sh  
config(aajohan-comfortaa-fonts) = 1.003-3.fc13
fontpackages-filesystem  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

aajohan-comfortaa-fonts-1.003-3.fc13.src.rpm
=
fontpackages-devel  
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1


SHOULD Items:

YES - Should build in mock.
YES - Should build on all supported archs
YES - Should function as described.
YES - Should have sane scriptlets.
NA - Should have subpackages require base package with fully versioned depend.
YES - Should have dist tag
YES - Should package latest version
NA - check for outstanding bugs on package. (For core merge reviews)

Issues:

1. fontconfig error when installing via yum localinstall

[root@turnip result]# yum localinstall --nogpgcheck
aajohan-comfortaa-fonts-1.003-3.fc13.noarch.rpm 
Loaded plugins: fastestmirror, presto, refresh-packagekit
Setting up Local Package Process
Examining aajohan-comfortaa-fonts-1.003-3.fc13.noarch.rpm:
aajohan-comfortaa-fonts-1.003-3.fc13.noarch
Marking aajohan-comfortaa-fonts-1.003-3.fc13.noarch.rpm to be installed
Loading mirror speeds from cached hostfile
updates/metalink                                         |  18 kB     00:00     
 * fedora: mirror.utexas.edu
 * rpmfusion-free: mirror.liberty.edu
 * rpmfusion-free-updates: mirror.liberty.edu
 * updates: mirror.utexas.edu
adobe-linux-i386                                         |  951 B     00:00     
rpmfusion-free-updates                                   | 2.8 kB     00:00     
updates                                                  | 4.5 kB     00:00     
Resolving Dependencies
--> Running transaction check
---> Package aajohan-comfortaa-fonts.noarch 0:1.003-3.fc13 set to be updated
--> Finished Dependency Resolution

Dependencies Resolved

================================================================================
 Package Arch   Version      Repository                                    Size
================================================================================
Installing:
 aajohan-comfortaa-fonts
         noarch 1.003-3.fc13 /aajohan-comfortaa-fonts-1.003-3.fc13.noarch 506 k

Transaction Summary
================================================================================
Install       1 Package(s)
Upgrade       0 Package(s)

Total size: 506 k
Installed size: 506 k
Is this ok [y/N]: y
Downloading Packages:
Running rpm_check_debug
Running Transaction Test
Transaction Test Succeeded
Running Transaction
  Installing     : aajohan-comfortaa-fonts-1.003-3.fc13.noarch              1/1 
Fontconfig error: "/etc/fonts/conf.d/61-aajohan-comfortaa.conf", line 5:
mismatched tag

Installed:
  aajohan-comfortaa-fonts.noarch 0:1.003-3.fc13                                 

Complete!


Fontconfig error is the only thing I see needing some editing, everything else
looks quite good.

-AdamM

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]