Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620862 --- Comment #4 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-08-03 16:32:37 EDT --- OK, I see you have some packages under your belt. Quick comments: %define name newt_syrup %define version 0.1.0 %define unmangled_version 0.1.0 %define release 2 All this is just noise, remove all. %define docdir %{python_sitelib}/%{name}-%{version}/doc This is evil, undone Summary: Newt Syrup is an app framework built on top of Newt Name: python-%{name} Version: %{version} Release: %{release}%{?dist} License: LGPLv2 See over Vendor: Darryl L. Pierce <dpierce@xxxxxxxxxx> Remove, Fedora is the vendor or all packages. Who has told you to add this? Url: http://newt-syrup.fedorahosted.org/ Source: http://mcpierce.fedorapeople.org/rpms/newt_syrup-%{unmangled_version}.tar.gz You are upstream for this package? How is the connection betwen http://newt-syrup.fedorahosted.org/ and this tarball? Group: Development/Libraries BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot Prefix: %{_prefix} What? Why are you defining prefix? BuildArch: noarch Requires: newt >= 0.52.11 BuildRequires: python-devel python-setuptools %description Newt Syrup is an app framework built on top of Newt. Some more words here would be nice. %prep %setup -q -n newt_syrup-%{version} %build %{__python} setup.py build %install rm -rf $RPM_BUILD_ROOT %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT %clean rm -rf $RPM_BUILD_ROOT %files %defattr(-,root,root) change to %defattr(-,root,root,-) %doc AUTHORS %doc ChangeLog %doc COPYING %{python_sitelib}/* You use three lines to list %doc, but a single wild card to list the important stuff? Please be more explicit. Do it simple for a quick review and provide a koji scratch build. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review