Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620862 --- Comment #2 from Darryl L. Pierce <dpierce@xxxxxxxxxx> 2010-08-03 15:59:22 EDT --- (In reply to comment #1) > Immediate comments: > > 1) > %define unmangled_version 0.1.0 > %define unmangled_version 0.1.0 > > is there twice? Hadn't realized it was pasted twice. I've removed it. > 2) > Requires: python(abi) >= 2.6 > > is not needed , it will be added anyway. Removed it. > 3) > > /usr/lib/python2.6/site-packages/src > /usr/lib/python2.6/site-packages/src/__init__.py > /usr/lib/python2.6/site-packages/src/__init__.pyc > /usr/lib/python2.6/site-packages/src/__init__.pyo > /usr/lib/python2.6/site-packages/src/configscreen.py > /usr/lib/python2.6/site-packages/src/configscreen.pyc > /usr/lib/python2.6/site-packages/src/configscreen.pyo > /usr/lib/python2.6/site-packages/src/menuscreen.py > /usr/lib/python2.6/site-packages/src/menuscreen.pyc > /usr/lib/python2.6/site-packages/src/menuscreen.pyo > > The "src" directory looks a bit odd, is that intended? I've now moved these up a level. New SPEC: http://mcpierce.fedorapeople.org/rpms/python-newt_syrup.spec New SRPM: http://mcpierce.fedorapeople.org/rpms/python-newt_syrup-0.1.0-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review