Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619928 --- Comment #4 from Matej Cepl <mcepl@xxxxxxxxxx> 2010-08-03 15:05:44 EDT --- (In reply to comment #3) > I find all of these worth addressing: > > tigase-server.noarch: E: zero-length /etc/tigase/database/derby-create-db.sql This is from the upstream tarball. I didn't think it harms anybody, but yes, certainly I can remove all zero-length files in database/. > tigase-server.noarch: E: incoherent-logrotate-file /etc/logrotate.d/tigase > Your logrotate file should be named /etc/logrotate.d/<package name>. > > tigase-server.noarch: W: no-reload-entry /etc/rc.d/init.d/tigase > In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload' > entry, which is necessary for good functionality. This is also caused by upstream. Their original idea was to have project tigase providing server, client, and webclient for XMPP. Currently only tigase-server exists, but we have two upstream packages which are not used by anything else (tigase-xmltools, tigase-utils) and package with too long name tigase-server. Given that the "tigase" is commonly used name of this software, I tried to use tigase instead of tigase-server, whenever I could. "tigase-server" seems like an awkward name for the binary. > 2.) Why is this needed? > > export LANG=en_US Yes, it isn't. Fixed. > This is pending import of tigase-utils and resolution of rpmlint warnings New src.rpm at http://mcepl.fedorapeople.org/rpms/tigase-server-5.0.0-0.2.20100527svn.src.rpm, new .spec file at the same location with new content -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review