Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608069 --- Comment #41 from Chen Lei <supercyper1@xxxxxxxxx> 2010-08-03 03:41:36 EDT --- Hi MERCIER, The spec seems almost fine, I only suggest to replace rm -rf %{name}/core/rt/compiler with rm -rf %{name}/core/rt, it seems core/rt is not useful for normally development. Look at the apidocs of tango[1], the files under core/rt are not documented here at all. Upstream binary tarball[2] also doesn't include this directory. Another question is there are several different opensource D compilers, is ldc far better than all other compilers(e.g. DMD)? If not, then I suggest to rename libtango.a to libtango-ldc.a as the name in the upstream tarball[2]. [1]http://www.dsource.org/projects/tango/docs/stable/ [2]http://downloads.dsource.org/projects/tango/0.99.9/tango-0.99.9-bin-linux32-ldc.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review