Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226457 --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-08-03 02:47:55 EDT --- sorry for later reply. (In reply to comment #2) > > > system-config-httpd.noarch: W: conffile-without-noreplace-flag > > /etc/alchemist/namespace/system-config-httpd/rpm.adl > > system-config-httpd.noarch: E: non-readable > > /etc/alchemist/namespace/system-config-httpd/rpm.adl 0600L > > system-config-httpd.noarch: E: non-readable > > /etc/alchemist/switchboard/system-config-httpd.switchboard.adl 0600L > > ==> If this is intended, can comments be added why noreplace flag and 600 > > permission needed? > > > > Well, the problem is that both rpm.adl and system-config-httpd.switchboard.adl > should probably never be modified by admins as they provide the basic config of > the tool (which might change for never versions). > > We can either make those "normal" files instead of config files (as they > shouldn't be modified in 99% of the cases) or i can add a comment, whatever you > prefer. If there is no harm in making those files as normal files then make those files as normal files. > > > system-config-httpd.noarch: W: dangerous-command-in-%pre mv > > system-config-httpd.noarch: W: dangerous-command-in-%preun rm > > ==> Is this needed here? > > > > The mv is definitely not needed anymore, so removed that. > > The rm commands i use to clean up leftover stuff in /var/cache and the pyc and > md5 check file i use. I can probably drop the pyc rm, but i'm not aware of how > else to fix the other leftover files other than removing them manually in one > of the uninstall sections of rpm. If there is i'll gladly use that. > Ok you can keep rest rm commands then. Please provide updated SRPM for further review. Once I see package is good you can commit and close this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review