Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gxine - Gnome frontend for the xine multimedia library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213511 ------- Additional Comments From martin.sourada@xxxxxxxxx 2006-11-13 09:54 EST ------- (In reply to comment #18) > It's probably not necessary to remove the non-free MIME types, otherwise, when > xine-lib-extras-nonfree is installed gxine would still not be used to open MP3s > etc. Back when Red Hat/Fedora still ships XMMS, it still would be set up to open > MP3s, it would just display a message informing the user that MP3 playback is > disabled. Yes, if it does not violate fedora guidelines than it is better to leave it as it is :-). > The latest .spec I posted as part of the review did have the BRs to have the > browser plugin built. I agree with Martin though that it probably should be > split into a subpackage. No, you don't build (I think) browser plug-in and you do not install it (at this point I am sure). Check INSTALL file for more info. You must copy or symlink the gxineplugin.so to /usr/lib/mozilla/plugins. About splitting: not necessary, I think, but all packages I have seen have browser plug-in in subpackage. > %find_lang is also used (Martin, check out > /usr/lib/rpm/find-lang.sh - it has a --all-name option that the version called > by %find_lang does not have). I just like the look of %find_lang more - I don't like hard-coded paths in spec file if not necessary. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review