Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473348 Rafael Aquini <aquini@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |aquini@xxxxxxxxx Flag| |fedora-review? --- Comment #9 from Rafael Aquini <aquini@xxxxxxxxx> 2010-08-02 12:54:28 EDT --- Xavier, I'm assigning this bug to me, and proceeding the formal review as follows. Good: * Package is named drraw which follows the upstream project name * spec file naming follows package naming * License in spec and sources is BSD which is open source * License text included in the tarball so no need to include one. * Spec is legible and American English * http://web.taranis.org/drraw/dist/drraw-2.2b2.tar.gz * Source matches upstream * No locale files * No shared libraries * No bundled libraries * Not relocatable * No directories created unowned * No duplicate files * Default permissions are set * Package is code * No large documentation * No %doc files are used at runtime * No header files * Not a GUI application * Does not own files or directories from other packages * All filenames are utf8 Needswork: * Patch files should have upstream issues opened to look good for our purposes * rpmlint complains about macros in comments: drraw.src:68: W: macro-in-comment %{SOURCE2} drraw.src:88: W: macro-in-comment %doc 1 packages and 0 specfiles checked; 0 errors, 2 warnings. * Minor adjusts needed to sections %post & %unpost at -selinux subpackage: %post selinux semanage fcontext -a -t httpd_sys_script_exec_t '%{_datadir}/%{name}(/.*)?' 2>/dev/null || : semanage fcontext -a -t httpd_sys_rw_content_t '%{_localstatedir}/lib/%{name}(/.*)?' 2>/dev/null || : restorecon -R %{_datadir}/%{name} %{_localstatedir}/lib/%{name} || : %postun selinux if [ $1 -eq 0 ] ; then semanage fcontext -d -t httpd_sys_script_exec_t '%{_datadir}/%{name}(/.*)?' 2>/dev/null || : semanage fcontext -d -t httpd_sys_rw_content_t '%{_localstatedir}/lib/%{name}(/.*)?' 2>/dev/null || : fi * Test builds in mock & koji -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review