Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619257 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-02 12:44:55 EDT --- For 1.1.6-1 * Unneeded macros - %ruby_sitelib macro seems to be used nowhere. * License - is actually "ASL 2.0" * BuildRoot - is no longer needed for Fedora and EPEL6. https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * Requires - "R: ruby(abi) = 1.8" is a must. https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines - ">= 0" part on "R: rubygem(rspec)" is redundant. * %files - %{geminstdir}/spec can be %doc - %{geminstdir}/stomp.gemspec is not needed. - Also would you consider to create -doc subpackage and move the following files to -doc? --------------------------------------------------------------- %{geminstdir}/spec %{geminstdir}/test %{geminstdir}/examples %{geminstdir}/Rakefile %{gemdir}/doc/%{gemname}-%{version} --------------------------------------------------------------- * %check - As this gem contains spec/ and test/ directory, please add %check section and execute some test program there (like $ rake spec or $ rake test ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review