Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620177 Kalev Lember <kalev@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalev@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kalev@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-08-02 10:49:51 EDT --- Taking for review. > License: GPLv2+ How did you determine that it is GPLv2+? uprof.c, uprof.h, and uprof-private.h all have LGPLv2+ headers and there's an LGPL COPYING file too. > find $RPM_BUILD_ROOT -name '*.a' -exec rm -f {} ';' It'd be nicer to pass --disable-static to configure so that the .a files don't get built in the first place. > BuildRequires: gtk-doc > BuildRequires: gnome-doc-utils Are these buildrequires necessary? There doesn't appear to be anything built with gtk-doc in the final rpms. The COPYING file is included in both base package and in the -devel subpackage. As per https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Subpackage_Licensing you can omit the COPYING file in -devel as it's dependant upon the base package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review