Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-activerecord - Implements the ActiveRecord pattern for ORM https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207473 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-11-13 01:15 EST ------- I noted the presence of a nice test suite, and realized that it should actually be possible to run at least some of it because sqlite doesn't need a configured database server. So I set out to get the test suite to run with: %check cd test ruby -I "connections/native_sqlite3" base_test.rb In order to get this to work, it's necessary to add some BRs: ruby(active_support), ruby(sqlite3), ruby-irb The first two are pretty obvious, but the third was not. It looks like the ruby-activesupport package needs a runtime dependency on ruby-irb. In any case, the test suite unfortunately fails: Using native SQLite3 SQLite3 database not found at /builddir/build/BUILD/activerecord-1.14.4/test/fixtures/fixture_database.sqlite3. Rebuilding it. Executing 'sqlite3 /builddir/build/BUILD/activerecord-1.14.4/test/fixtures/fixture_database.sqlite3 "create table a (a integer); drop table a;"' SQLite3 database not found at /builddir/build/BUILD/activerecord-1.14.4/test/fixtures/fixture_database_2.sqlite3. Rebuilding it. Executing 'sqlite3 /builddir/build/BUILD/activerecord-1.14.4/test/fixtures/fixture_database_2.sqlite3 "create table a (a integer); drop table a;"' -- create_table(:taggings, {:force=>true}) -> 0.0158s -- create_table(:tags, {:force=>true}) -> 0.0160s -- create_table(:categorizations, {:force=>true}) -> 0.0158s -- add_column(:posts, :taggings_count, :integer, {:default=>0}) -> 0.0182s -- add_column(:authors, :author_address_id, :integer) -> 0.0162s -- create_table(:author_addresses, {:force=>true}) -> 0.0173s -- create_table(:author_favorites, {:force=>true}) -> 0.0240s Loaded suite base_test Started .......................................................................................................F............. Finished in 0.519048 seconds. 1) Failure: test_to_xml_including_multiple_associations(BasicsTest) [base_test.rb:1248]: <false> is not true. 117 tests, 297 assertions, 1 failures, 0 errors It would be good to figure out what's going wrong here just in case there is an actual problem with the code on this platform. Review: * source files match upstream: ce66299a7fe99fdaf2c9747e850560b6 activerecord-1.14.4.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: ruby(active_record) = 1.14.4 ruby-activerecord = 1.14.4-1.fc7 = ruby(abi) = 1.8 ruby(active_support) ? Not sure about %check. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review