Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619518 --- Comment #12 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> 2010-07-30 14:04:00 EDT --- Spec URL: http://luya.fedorapeople.prg/packages/SPECS/aajohan-comfortaa-fonts.specs SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/aajohan-comfortaa-fonts-1.003-3.fc13.src.rpm (In reply to comment #11) > 1. There is no need to ask upstream to fix the documentation, as it is already > in the archive. You need to provide these files as part of the package: > > Please read me.txt > Comfortaa FONTLOG.txt > OFL - Font License.txt Added but I received these warnings: $ rpmlint rpmbuild/RPMS/noarch/aajohan-comfortaa-fonts-1.4-3.fc13.noarch.rpm aajohan-comfortaa-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/aajohan-comfortaa-fonts-1.4/Please read me.txt aajohan-comfortaa-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/aajohan-comfortaa-fonts-1.4/Comfortaa FONTLOG.txt aajohan-comfortaa-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/aajohan-comfortaa-fonts-1.4/OFL - Font License.txt 1 packages and 0 specfiles checked; 0 errors, 3 warnings. I am not sure where wrong-file-of-line-encoding come from. Will those impact packaging process? > 2. The reason that the original fontconfig was wrong is that it was suggesting > that Comfortaa is the same design as MgOpen Modata, which it is not. That was an attempt but the wiki documentation is not clear so I was stuck with wild guess. With TK009, I settled to generic fontconfig. > 3. Why are you using 1.4 as the version number? The archive has no version > number and the font files themselves are version 1.003. Fixed. I based version number on the Please Readme text -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review