Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583531 --- Comment #15 from Adam Miller <maxamillion@xxxxxxxxxxxxxxxxx> 2010-07-30 11:53:45 EDT --- NO - Package meets naming and packaging guidelines FIXME: Package should be named firetray as that is the name of the upstream project YES - Spec file matches base package name. YES - Spec has consistant macro usage. - Meets Packaging Guidelines. YES - License YES - License field in spec matches YES - License file included in package YES - Spec in American English YES - Spec is legible. NO - Sources match upstream md5sum: Invalid Source0 URL Source0: http://%{upname}.googlecode.com/files/%{upname}-%{version}-src.zip NA - Package needs ExcludeArch YES - BuildRequires correct NA - Spec handles locales/find_lang NA - Package is relocatable and has a reason to be. YES - Package has %defattr and permissions on files is good. YES - Package has a correct %clean section. YES - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) YES - Package is code or permissible content. NA - Doc subpackage needed/used. YES - Packages %doc files don't affect runtime. NA - Headers/static libs in -devel subpackage. NA - Spec has needed ldconfig in post and postun NA - .pc files in -devel subpackage/requires pkgconfig NA - .so files in -devel subpackage. NA- -devel package Requires: %{name} = %{version}-%{release} NA - .la files are removed. NA - Package is a GUI app and has a .desktop file YES - Package compiles and builds on at least one arch. YES - Package has no duplicate files in %files. YES - Package doesn't own any directories other packages own. YES - Package owns all the directories it creates. NO - No rpmlint output. [10:49:31][adam@turnip][SPECS]+ rpmlint ../SRPMS/mozilla-firetray-0.2.8-1.fc13.src.rpm mozilla-firetray.src: W: spelling-error Summary(en_US) addon -> ad don, ad-don, add on mozilla-firetray.src: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-firetray.src: W: spelling-error %description -l en_US firefox -> Firefox, firebox, fire fox mozilla-firetray.src: W: spelling-error %description -l en_US thunderbird -> Thunderbird, thunder bird, thunder-bird mozilla-firetray.src: W: spelling-error %description -l en_US iconified -> personified, iconicity, nonunified mozilla-firetray.src: W: spelling-error %description -l en_US deiconify -> deification, personify, Delmonico mozilla-firetray.src:79: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version} mozilla-firetray.src:80: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/License.txt mozilla-firetray.src:81: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/defaults mozilla-firetray.src:82: W: unversioned-explicit-provides %{_datadir}/doc/%{name}-core-%{version}/ChangeLog mozilla-firetray.src:83: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/install.rdf mozilla-firetray.src:84: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/chrome mozilla-firetray.src:85: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/chrome.manifest mozilla-firetray.src:86: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/components/nsITray.xpt mozilla-firetray.src:87: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/components/nsMinimize.js mozilla-firetray.src:88: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/components/nsIMinimize.xpt mozilla-firetray.src: W: invalid-url Source0: http://firetray.googlecode.com/files/firetray-0.2.8-src.zip HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 17 warnings. YES - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) [10:50:36][adam@turnip][result]+ for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done mozilla-firetray-0.2.8-1.fc13.src.rpm = xulrunner-devel scons zip unzip rpmlib(FileDigests) <= 4.6.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mozilla-firetray-chatzilla-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-chatzilla = 0.2.8-1.fc13 mozilla-firetray-chatzilla(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/lib64/mozilla-firetray-0.2.8/chrome /usr/lib64/mozilla-firetray-0.2.8/chrome.manifest /usr/lib64/mozilla-firetray-0.2.8/components/nsIMinimize.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsITray.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsMinimize.js /usr/lib64/mozilla-firetray-0.2.8/defaults /usr/lib64/mozilla-firetray-0.2.8/install.rdf /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog chatzilla mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-core-0.2.8-1.fc13.x86_64.rpm /usr/lib64/mozilla-firetray-0.2.8 /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/lib64/mozilla-firetray-0.2.8/chrome /usr/lib64/mozilla-firetray-0.2.8/chrome.manifest /usr/lib64/mozilla-firetray-0.2.8/components/nsIMinimize.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsITray.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsMinimize.js /usr/lib64/mozilla-firetray-0.2.8/defaults /usr/lib64/mozilla-firetray-0.2.8/install.rdf /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog libnptray.so()(64bit) mozilla-firetray-core = 0.2.8-1.fc13 mozilla-firetray-core(x86-64) = 0.2.8-1.fc13 = libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-debuginfo-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-debuginfo = 0.2.8-1.fc13 mozilla-firetray-debuginfo(x86-64) = 0.2.8-1.fc13 = rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-firefox-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-firefox = 0.2.8-1.fc13 mozilla-firetray-firefox(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/lib64/mozilla-firetray-0.2.8/chrome /usr/lib64/mozilla-firetray-0.2.8/chrome.manifest /usr/lib64/mozilla-firetray-0.2.8/components/nsIMinimize.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsITray.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsMinimize.js /usr/lib64/mozilla-firetray-0.2.8/defaults /usr/lib64/mozilla-firetray-0.2.8/install.rdf /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog firefox mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-seamonkey-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-seamonkey = 0.2.8-1.fc13 mozilla-firetray-seamonkey(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8 /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 seamonkey rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-sunbird-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-sunbird = 0.2.8-1.fc13 mozilla-firetray-sunbird(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8 /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 sunbird rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-thunderbird-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-thunderbird = 0.2.8-1.fc13 mozilla-firetray-thunderbird(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8 /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 thunderbird rpmlib(PayloadIsXz) <= 5.2-1 SHOULD Items: YES - Should build in mock. YES - Should build on all supported archs YES - Should function as described. NA - Should have sane scriptlets. YES - Should have subpackages require base package with fully versioned depend. YES - Should have dist tag YES - Should package latest version NA - check for outstanding bugs on package. (For core merge reviews) Issues: 1. Not really an issue, but a suggestion to changing the %define macros to %global. 2. Fix the line items with a "NO" on them from the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review