Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590244 --- Comment #10 from Andrea Musuruane <musuruan@xxxxxxxxx> 2010-07-30 10:58:17 EDT --- * It seems the koji build has not been done with the uploaded spec file because I see you used desktop-file-install in the koji build and desktop-file-validate in the spec file. * The license file "license-pdn.txt" is missing among docs. * All patches in Fedora spec files SHOULD have a comment above them about their upstream status. Any time you create a patch, it is best practice to file it in an upstream bug tracker, and include a link to that in the comment above the patch. https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment This was still another quick glance. I hope to have a closer look next weekend. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review