Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619518 --- Comment #2 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> 2010-07-29 18:46:15 EDT --- Spec URL: http://luya.fedorapeople.prg/packages/SPECS/aajohan-comfortaa-fonts.specs SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/aajohan-comfortaa-fonts-1.4-2.fc13.src.rpm $ rpmlint rpmbuild/SRPMS/aajohan-comfortaa-fonts-1.4-2.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings(In reply to comment #1) > Hi, > here is an informal review, since I'm not (yet) a sponsored packager. > rpmlint outputs : > aajohan-comfortaa-fonts.src: E: description-line-too-long C Comfortaa is a > sans-serif font intended to mimic Gill Sans. It has Regular, Light Condensed, > Italic, Bold Expanded, and Bold Italic variants. It has very good European > language coverage and also has decent Cyrillic coverage. > ->Add breaklines so that the lines in your description are less than > 80-character wide. Fixed. > aajohan-comfortaa-fonts.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line > 4, tab: line 13) > check it ;-) Habit inherited from using Scribus. =) > -n is used to specify the name of the extracted source archive : in your case > the good syntax is: > %setup -q -n Comfortaa > By the way, the %build section doesn't need neither %configure, nor %build: the > archive only contains ttf files, no build is required (see the guidelines: > http://fedoraproject.org/wiki/Packaging:FontsPolicy). rpmlint was whining about lack of %build so I left it to remove the warning message. > Moreover, your %files section looks quite empty... Removed. Finally the spec file in the > source RPM is not really complete, and the spec URL you given above is not > correct. I hope you uploaded a draft version of your SRPM by mistake, otherwise Yes I did. The correct version is now uploaded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review