Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619518 alexisis-pristontale@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexisis-pristontale@hotmai | |l.com --- Comment #1 from alexisis-pristontale@xxxxxxxxxxx 2010-07-29 15:27:59 EDT --- Hi, here is an informal review, since I'm not (yet) a sponsored packager. rpmlint outputs : aajohan-comfortaa-fonts.src: E: description-line-too-long C Comfortaa is a sans-serif font intended to mimic Gill Sans. It has Regular, Light Condensed, Italic, Bold Expanded, and Bold Italic variants. It has very good European language coverage and also has decent Cyrillic coverage. ->Add breaklines so that the lines in your description are less than 80-character wide. aajohan-comfortaa-fonts.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 13) check it ;-) -> Be careful to use spaces instead of tabs in BuildArch and Requires The build fails: + cd Comfortaa___font_by_aajohan.zip /var/tmp/rpm-tmp.LhrifH: line 38: cd: Comfortaa___font_by_aajohan.zip: No such file or directory -> Line 24 is false: %setup -q -n Comfortaa___font_by_aajohan.zip -n is used to specify the name of the extracted source archive : in your case the good syntax is: %setup -q -n Comfortaa By the way, the %build section doesn't need neither %configure, nor %build: the archive only contains ttf files, no build is required (see the guidelines: http://fedoraproject.org/wiki/Packaging:FontsPolicy). Moreover, your %files section looks quite empty... Finally the spec file in the source RPM is not really complete, and the spec URL you given above is not correct. I hope you uploaded a draft version of your SRPM by mistake, otherwise it would be worrying to submit such an incomplete package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review