Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617400 --- Comment #6 from Kevin Fenzi <kevin@xxxxxxxxx> 2010-07-28 13:10:36 EDT --- Cool. We are getting there. ;) 1. Thats fine, but: a) You can just do "%doc COPYING README". No need to use _defaultdocdir or the like. b) You seem to have changed the upstream release contents without changing the release. This is not good practice. Anytime you change the contents, make a new release. Now when people look at the '1' version they won't know if it's the one without COPYING and README changes or not. ;) c) You have in README: "See COPYING for licensing information" Which is not explicit enough. Just based on copying, the license here would be "GPL+" ie, any version of the gpl ever published. ;) If you just want v2, say "This package is released under the GPLv2 only" 2. Looks good. 3. Excellent. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review