Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618985 --- Comment #4 from Jan Kaluža <jkaluza@xxxxxxxxxx> 2010-07-28 11:05:01 EDT --- I've updated the spec file and srpm: Spec URL: http://jkaluza.fedorapeople.org/swift.spec SRPM URL: http://jkaluza.fedorapeople.org/swift-1.0-0.2.beta5.fc13.src.rpm (In reply to comment #2) > %description should be longer. Fixed. > Where does swift.xpm (Source2) come from? It was brought from Debian package, but I've just removed it and new spec file uses icon from Source0 tarball. > You do not need to define "BuildRoot:..." anymore, rpmbuild will use a sane one > automatically (since F-10). > You do not need to clean the buildroot manually at the beginning of %install > (since F-10). > You do not need the %clean section either (since F-13). > http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Thanks, fixed. > It's good that you remove bundled libraries in %prep. Only why you do not > remove all of them? The "3rdParty" directory still contains: > Boost CppUnit DocBook hippomocks.h LCov I've removed all unused bundled libraries. DocBook is still used, because build fails with DocBook from rawhide. I will ask upstream for help, but it's only build-time dependency, so it should not be problem just now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review