Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618761 --- Comment #4 from Jessica Jones <fedora@xxxxxxxxxxx> 2010-07-28 05:45:08 EDT --- (In reply to comment #3) <snip> > [!] Package does not contain duplicates in %files. <snip> > === COMMENTS === > > Only the LICENSE file should be included in all the %doc stansas. (the rest > should be based on what's appropriate, normally just the main package) > > While the spec file is legible, it's supposed to be en_US > timeframe -> time frame, time-frame Is there some way to check this sort of thing (I am finding conflicting sources)? I copied the description from the website, which is in US English as far as I know. > file-not-utf8 (LICENSE, README) > # standard fix (preserving timestamps) > iconv -f iso8859-1 -t utf8 README >README.utf8 > touch -r README README.utf8 > mv README.utf8 README Do you want me to add that to the spec file? > Ignore the lack of man-page messages, upstream don't provide them and there is > other documentation. > > non-conffile-in-etc (/etc/gold(|g|d).conf > - Use the %conf macro > > macro-in-comment > - Ignore, > Okay will do. > Is there a make test rule (that doesn't require a database)? If so it *should* > be used. No there isn't. I already looked into this, and there isn't a make check either. I have been talking to the upstream maintainer off-list about this and other issues, so it may appear later. > It's worth running a recent rpmlint over all the files before submitting, the > EL-5 rpmlint is rather out of date. It would be nice if the people.fedoraproject.org servers had the koji client and rpmlint (and rpmbuild for creating SRPMs) on them. I will have to spend some time setting up a VM so that I can use it to build otherwise. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review