[Bug 591415] Review Request: R-timeDate - Rmetrics - chronological and calendarical objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591415

Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #10 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2010-07-28 03:09:11 EDT ---
* Latest version packaged
895b9ddfc48604ed908b0689cfeeb728d96ecc73  timeDate_2120.90.tar.gz
895b9ddfc48604ed908b0689cfeeb728d96ecc73 
/home/pierrey/rpmbuild/SOURCES/timeDate_2120.90.tar.gz
* sha1sum are equals
- You should change the Require to R into R-core
  Not all mandatory Requires are present in ['R', 'R-RUnit']
* All required BuildRequires are present
* The macro %check is present
* There is 1 %dir
  %dir is OK
* There is 4 %doc

* The rpm installed in _datadir
* The rpm uses %{_datadir} and is noarch
* The rpm seems to have the required element in %install
LANG=C rpmbuild -ba /home/pierrey/rpmbuild/SPECS/R-timeDate.spec >
R-timeDate.spec-build.log 2>&1 
* Build properly under 2.6.33.6-147.fc13.x86_64
* rpmlint:
R-timeDate.src: W: spelling-error Summary(en_US) Rmetrics -> Metrics, R
metrics, Metricates
R-timeDate.src: W: spelling-error Summary(en_US) calendarical -> calendrical,
calendar, calendric
R-timeDate.noarch: W: spelling-error Summary(en_US) Rmetrics -> Metrics, R
metrics, Metricates
R-timeDate.noarch: W: spelling-error Summary(en_US) calendarical ->
calendrical, calendar, calendric
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Scratch build on koji for target f14
* Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2355826
   0 free  0 open  2 done  0 failed
   2355826 build (dist-f14, R-timeDate-2120.90-1.fc12.src.rpm) completed
successfully

* Build is clean from warnings or errors
* All checks are passed
* License (GPLv2+) is compatible with Fedora
* Warnings from rpmlint are safe to ignore (although calendarical might be
worth to change)

I trust you can fix the Requires issue before importing the package into the
CVS, therefore this package is 

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]