Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615669 --- Comment #13 from Kevin Fenzi <kevin@xxxxxxxxx> 2010-07-28 00:50:38 EDT --- 1, 2, 3, all look good. on 4: You can replace: %doc %{_defaultdocdir}/perl-Crypt-Cracklib-%{version}/Changes %doc %{_defaultdocdir}/perl-Crypt-Cracklib-%{version}/README with just: %doc Changes README 5. I think this falls under: https://fedoraproject.org/wiki/Packaging/Guidelines#Multiple_packages_own_files_in_a_common_directory_but_none_of_them_needs_to_require_the_others. I see currently all of the following own this dir: perl-Crypt-OpenSSL-PKCS10-0:0.06-15.fc14.x86_64 perl-Crypt-OpenSSL-Random-0:0.04-12.fc14.x86_64 perl-Crypt-DES-0:2.05-11.fc14.x86_64 perl-Crypt-OpenSSL-X509-0:0.7-7.fc14.x86_64 perl-Crypt-Eksblowfish-0:0.008-2.fc14.x86_64 perl-Crypt-Twofish-0:2.14-2.fc14.x86_64 perl-Crypt-OpenSSL-RSA-0:0.25-12.fc14.x86_64 perl-Crypt-SSLeay-0:0.57-17.fc14.x86_64 perl-Crypt-OpenSSL-AES-0:0.02-11.fc14.x86_64 perl-Crypt-Rijndael-0:1.09-2.fc14.x86_64 perl-Crypt-Blowfish-0:2.10-10.fc14.x86_64 crypto-utils-0:2.4.1-27.x86_64 perl-Crypt-OpenSSL-Bignum-0:0.04-10.fc14.x86_64 perl-Crypt-OpenSSL-DSA-0:0.13-16.fc14.x86_64 perl-Crypt-SMIME-0:0.09-4.fc14.x86_64 6 and 7: ok. I see you have a Epoch: 1 here. Why? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review