Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618451 Dave Malcolm <dmalcolm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tromey@xxxxxxxxxx --- Comment #5 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2010-07-27 12:03:59 EDT --- (In reply to comment #4) > The license tag should be: > > License: LGPLv2+ and Python Fixed > Also, you're using mixed macros ($RPM_BUILD_ROOT vs %{buildroot}). I would > suggest that you standardize on the latter. Fixed > I'm a little concerned about the forced dependency on > /usr/lib/debug/lib*/ld-2.11.2.so.debug, as technically, the package that > provides it (glibc-debuginfo) is not part of the normal repositories, so this > package will not be installable without the user consciously enabling the > debuginfo repo. > > Perhaps a cleaner approach would be for the command to check on invocation for > presence of that library, and if not found, prompt the user to run the > appropriate "debuginfo-install" command, similar to gdb's behavior when it hits > missing debuginfo during a debug run. This code is autoloaded by gdb when the libc.so.debug is loaded by gdb (in response to libc.so is loaded in the inferior process) i.e. when the DWARF debug info for glibc is loaded by gdb. Hence if that file isn't present, the code is not autoloaded or run, and thus isn't able to issue a warning message. I've changed this to a dependency on: Requires: glibc%{_isa} = %{glibc_version} though this really ought to read: Requires: glibc-debuginfo%{_isa} = %{glibc_version} as that's what it really needs. Without the debuginfo package this code not only is useless, but won't load or run. I don't know if it's possible to rig things up so that this autoloaded whenever gdb starts up (CCing tromey for gdb advice), that way we could issue a message. (Though it strikes me that this ought to be handled at the rpm metadata level, not as a runtime failure, and that we ought to allow packages that require debuginfo to require that debuginfo). Updated specfile: http://dmalcolm.fedorapeople.org/python-packaging/gdb-heap.spec Updated SRPM: http://dmalcolm.fedorapeople.org/python-packaging/gdb-heap-0.1-2.fc12.src.rpm Specfile changes: http://dmalcolm.fedorapeople.org/python-packaging/from-0.1-1-to-0.1-2.diff -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review