Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=427484 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@xxxxxxxxxxxx --- Comment #9 from Paul Howarth <paul@xxxxxxxxxxxx> 2010-07-26 05:40:19 EDT --- (In reply to comment #7) > publican-redhat.spec:22: W: unversioned-explicit-obsoletes > documentation-devel-%{brand} > publican-redhat.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: > line 5) > > Please fix the mixed-use-of-spaces-and-tabs. I don't think the > unversioned-explicit-obsoletes is an issue. (However, someone correct me if I'm > wrong). It's a problem if anyone ever wishes to introduce a package (with any version number) called documentation-devel-%{brand} in the future. It's not unheard of for packages to be renamed one way and then back to the original name, or completely new packages to be introduced with names that have been used for something else in the past, so best practice is to use a versioned obsolete such as: Obsoletes: documentation-devel-%{brand} <= V-R where V-R is the version/release (including the dist tag, if any) of the last build using the old name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review