Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=616354 --- Comment #4 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-07-26 04:53:56 EDT --- (In reply to comment #3) > NEEDSWORK: rpmlint must be run on every package. The output should be posted in > the review. > > geronimo-jpa.spec:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: > line 4) > -> NEEDSWORK Fixed > Notes: > * You require an explicit jpackage version in the javadoc subpackage, but an > unversioned in %post and %postun. Wanted behaviour? Unwanted, fixed. > * You just re-use the summary as javadoc description. Wouldn't it be nicer to > say something like "This package contains the API documentation for..." Yes but my summary is: "API documentation for %{name}". It's short enough for summary and descriptive enough for description IMO. I could change this if you feel strong enough about it :-) Spec URL: http://sochotni.fedorapeople.org/packages/geronimo-jpa.spec SRPM URL: http://sochotni.fedorapeople.org/packages/geronimo-jpa-1.1.1-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review