[Bug 531107] Review Request: perl-SQL-Tokenizer - A Perl package to tokenize SQL, generically

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531107

Marcela Mašláňová <mmaslano@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |mmaslano@xxxxxxxxxx

--- Comment #9 from Marcela Mašláňová <mmaslano@xxxxxxxxxx> 2010-07-26 04:39:38 EDT ---
- rpmlint checks return: OK
perl-SQL-Tokenizer.src: E: unknown-key GPG#b73652a5
 ^ looks like you've signed your package. This should be ok.
- package meets naming guidelines OK
- package meets packaging guidelines OK
- license (GPL+ or Artistic) OK, text in %doc, matches source
- spec file legible, in am. english OK
- source matches upstream OK
- package compiles on devel (x86) OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=2350781
- no missing BR OK
- no unnecessary BR NOT OK
 please remove Test::More from Requires. This is needed only during build.
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean ok OK
- macro use consistent OK
- code, not content OK
- no need for -docs OK
- nothing in %doc affects runtime OK
- no need for .desktop file  OK

Almost ok ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]