Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=614047 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #1 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> 2010-07-25 16:20:32 EDT --- $ rpmlint mingw32-spice-protocol.spec mingw32-spice-protocol.spec: W: no-cleaning-of-buildroot %install mingw32-spice-protocol.spec: W: no-cleaning-of-buildroot %clean mingw32-spice-protocol.spec: W: no-buildroot-tag mingw32-spice-protocol.spec: W: no-%clean-section 0 packages and 1 specfiles checked; 0 errors, 4 warnings. - Please fix the rpmlint warnings mentioned above - Please use %global instead of %define for all the macros at the top of the .spec file - Please use %defattr(,-,root,root,-) instead of %defattr(-,root,root) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review