Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617340 d. johnson <drjohnson1@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |drjohnson1@xxxxxxxxx --- Comment #3 from d. johnson <drjohnson1@xxxxxxxxx> 2010-07-25 15:11:54 EDT --- Please note, I am not an an official packager. - Package meets naming and packaging guidelines - Spec file matches base package name. - Spec has consistent macro usage. - Meets Packaging Guidelines. - License - License field in spec matches - License file included in package - Spec in American English - Spec is legible. - Sources match upstream md5sum: - Package does not need ExcludeArch - BuildRequires correct - Spec handles locales/find_lang (none found in package) - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot - Package is code or permissible content. - Doc subpackage not needed/used. - Packages %doc files don't affect runtime. - Package is a not a GUI app - Package compiles and builds on at least one arch. - Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - Package owns all the directories it creates. - No rpmlint output. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done SHOULD Items: - Should build in mock. (Does.) - Should build on all supported archs (Builds on both i686 and x86_64) - Should function as described. (Does) - Should have sane scriptlets. (None) - Should have subpackages require base package with fully versioned depend. (None) - Should have dist tag (Does) - Should package latest version (Does) - check for outstanding bugs on package. (For core merge reviews) % rpmlint throttle-*1.2-3.fc1*.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review