Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 --- Comment #11 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-07-25 13:03:04 EDT --- Sorry for late. Again please use <integer>%{?dist} for release number unless the tarball is preversion or so. * Requires(foo) - Please unify Requires(foo) to "/sbin/service" type or "initscripts" style, not use both, ref: https://fedoraproject.org/wiki/Packaging/SysVInitScript#InitscriptScriptlets - Some Requires(pre) is missing: https://fedoraproject.org/wiki/Packaging/UsersAndGroups * Macros - Please use macros consistently. - If you want to use %{__rm} or %{__install}, please also use %{__make}, %{__mkdir_p}, %{__ln_s} or so. Also both "%{__rm}" and rm are used. * service name - Now rpmlint complains: ------------------------------------------------------------ clamsmtp.i686: E: init-script-name-with-dot /etc/rc.d/init.d/clamd.clamsmtp ------------------------------------------------------------ Please check "$ rpmlint -I init-script-name-with-dot" for explanation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review