Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608069 --- Comment #22 from Chen Lei <supercyper1@xxxxxxxxx> 2010-07-25 08:11:52 EDT --- (In reply to comment #21) > 1/ yes is Multiple license > http://www.dsource.org/projects/tango/wiki/LibraryLicense So you need to use 'or' instead of 'and' in license field. > 3/ remove files %{name}/core/rt/compiler/[gdc|dmd] it is not used for build > tango with ldc. Can we remove the whole %{name}/core/rt directory in %install section, are files under %{name}/core/rt/ldc compiled into libtango.a? It seems upstream tarballs don't include %{name}/core/rt. > 4/ why put object.di out of tango directory? Upstream tarballs and other distribution put object.di outside tango dir. It'll be better to keep close with upstream. See http://downloads.dsource.org/projects/tango/0.99.9/tango-0.99.9-bin-linux32-ldc.tar.gz http://downloads.dsource.org/projects/tango/0.99.9/tango-0.99.9-bin-linux64-ldc.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review