Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608069 --- Comment #20 from Chen Lei <supercyper1@xxxxxxxxx> 2010-07-25 03:39:57 EDT --- Some more comments: 1.License: AFL and BSD Please recheck this license and add a comments if it's really a Multiple Licensing Scenarios rather than Dual Licensing Scenarios http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Dual_Licensing_Scenarios 2. %prep %setup -q -n %{name}-%{alphatag}%{svn_revision} rm -rf ./build/bin/freebsd32 rm -rf ./build/bin/osx32 rm -rf ./build/bin/win32 Please remove all binaries in %prep. rm -rf ./build/bin/* 3. rm -rf %{name}/core/rt/compiler/gdc rm -rf %{name}/core/rt/compiler/dmd I wonder if it's safe to remove %{name}/core/rt/ completely here, offical tango tarball don't include those files. See http://www.dsource.org/projects/tango/wiki/TopicInstallTangoLdc 4. cp -rp object.di %{buildroot}%{_includedir}/d/%{name}/ ->cp -rp object.di %{buildroot}%{_includedir}/d 5. %files %defattr(-,root,root,-) %doc README.txt LICENSE.txt %{_libdir}/%{name}/libtango.a %files devel %defattr(-,root,root,-) %doc doc/example doc/html/ %{_includedir}/d/%{name} -> %files devel %defattr(-,root,root,-) %doc README.txt LICENSE.txt %doc doc/example doc/html/ %{_libdir}/%{name}/libtango.a %{_includedir}/d/%{name} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review