[Bug 617877] Review Request: txmpp - A C++ XMPP library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617877

Chen Lei <supercyper1@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |supercyper1@xxxxxxxxx

--- Comment #1 from Chen Lei <supercyper1@xxxxxxxxx> 2010-07-25 02:16:25 EDT ---
Spec is sane, only some minor issues:

1.BuildRequires:    expat2-devel >= 2.0.1

expat2 don't exist in both Fedora and EPEL, why add expat2-devel as a BR? 

2.%files devel
%doc README.md
You can safely ignore some rpmlint warnings(e.g. no documentation, wrong spell,
etc.), duplicate files in %file are not needed normally.

3. Group for main package should be System Environment/Libraries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]