Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592733 --- Comment #10 from Chen Lei <supercyper1@xxxxxxxxx> 2010-07-25 00:58:28 EDT --- Several minor issues: 1. BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %install rm -rf %{buildroot} buildroot and cleaning %{buildroot} in %install section is not needed in fedora. 2. %setup -q -n turpial-1.3.3 ->%setup -q 3. Summary: Is cool twitter client with many features and very light ->Summary: Cool twitter client with many features and very light 4. %find_lang %{name} cat %{name}.lang > %{name}-all.lang Why rename %{name}.lang to %{name}-all.lang? 5. %attr(0755,root,root) %{python_sitelib}/%{name}/main.py Why add excutable bit for main.py? Normally, %attr is not needed in %file. %{python_sitelib}/%{name}/main.py should not be listed seperately, list files twice in %file is forbidden in spec. 6. BuildRequires: python-babel >= 0.9.1, python2-devel python-setuptools Requires: python-simplejson >= 1.9.2, python-imaging notify-python >= 0.1.1, pygame >= 1.7, pygtk2 >= 2.12, pywebkitgtk gnome-python2-gtkspell >= 2.25.3 Please check the version of those packages in F12, if the version in F12 > minimum version, then you should not use versioned requirement. e.g. pygtk2 >= 2.12 -> pygtk2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review