Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607584 --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-07-24 15:57:39 EDT --- For 0.3b-1: * BuildRoot tag - As I said in the previous comment, BuildRoot tag is no longer needed on Fedora, only needed on EPEL-5. If you want to import this package only into Fedora 12-14, please remove BuildRoot tag. * BuildRequires - Please list BuildRequires which are really needed when building this srpm. As far as I checked, "BR: python2-devel desktop-file-utils" is enough - i.e. "BR: gstreamer-python-devel pygtk2, gtk2" is unneeded. * Unneeded Obsoletes - "Obsoletes: %{name} < 0.3b" is unneeded and should be removed. * %setup - By default %setup uses %{name}-%{version} for default directory and "-n %{name}-%{version}" part is unneeded. * Directory ownership issue - Still the directory %{_datadir}/wordgroupz/ itself is not owned by any packages: https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory * Desktop file - As I said in the previous comment, "Application" in "Categories" item is deprecated and should be removed. * %changelog - Please make the last entry of %changelog match the current EVR (Epoch-Version-Release) of the spec file (%changelog says the latest is 0.3b-2, while current EVR is 0.3b-1) - It is recommended (for Fedora VCS) that you put one line between each %changelog entry like ------------------------------------------------------------------------------ * Sat Jul 24 2010 rtnpro <rtnpro@xxxxxxxxx> 0.3b-2 - Included dependencies for pygst and beautifulsoup * Fri Jul 23 2010 rtnpro <rtnpro@xxxxxxxxx> 0.3b-1 - Release version 0.3b * Thu Jun 24 2010 rtnpro <rtnpro@xxxxxxxxx> 0.2-1 - Initial RPM package------------------------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review