Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #3 from Ben Boeckel <mathstuf@xxxxxxxxx> 2010-07-24 14:29:20 EDT --- (In reply to comment #2) > Well, another interesting file manager :) I have another one queued up, but it still needs some work and isn't actively maintained AFAICS. :) > Some notes: > > ! python2 vs python3 > - As your spec file uses %{python_sitelib} which is python2 > specific macro, I think explicitly writing "BR: python2-devel" > rather than "BR: python-devel" is preferable. > https://fedoraproject.org/wiki/Packaging/Python#BuildRequires Done. > ! BuildRoot > - BuildRoot tag is no longer needed on Fedora (only needed > on EPEL5) > https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Oops, yeah. rpmdev-newspec template got me here. > ! default %setup > - By default %setup uses "%{name}-%{version}". so explicitly writing > "-n %{name}-%{version}" is not needed. Yeah, I do this out of habit because some of the packages I maintain I do snapshots at times (Rawhide and my personal repo) and this keeps the diffs low. Looking closer at the release windows, it looks like I won't need to do many here. Removing. > * rpmlint issue > --------------------------------------------------------- > ranger.noarch: E: non-executable-script > /usr/lib/python2.6/site-packages/ranger/__main__.py 0644L /usr/bin/env > --------------------------------------------------------- > - This file need not have shebang. Patch included. Bug filed upstream (link in request). % lintmock fedora-13-x86_64-bb ranger.src: W: strange-permission ranger-1.1.2-remove-shebang.patch 0640L ranger.src: W: strange-permission ranger.spec 0640L ranger.src: W: strange-permission ranger-1.1.2.tar.gz 0640L ranger.src: W: no-buildroot-tag 2 packages and 0 specfiles checked; 0 errors, 4 warnings Spec URL: http://blipper.dev.benboeckel.net/files/pkg/ranger.spec SRPM URL: http://blipper.dev.benboeckel.net/yum/13/x86_64/src/ranger-1.1.2-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review